Description

The base node and console wallet have various immediate exit paths through 'process::exit', as well as controlled exit via user/shutdown command.

• This implementation uses a unique but predictable handshake file containing the libtor temporary directory for each base node or console wallet running instance to cover all exit paths. When the main thread exits, via user command or 'process::exit', the libtor temporary files and the handshake file are removed. does away with the temporary libtor data folder and log file and instead uses a fixed or user-controllable location via the --libtor-data-dir command line option.

• Added libtor exiting logic to:

  • log any shutdown errors;
  • remove temporary files.

• Added a failsafe timeout for test-liveness.

Closes #6739 and #6741

Motivation and Context

See #6739 and #6741

How Has This Been Tested?

System-level testing:

• Base node (Ubuntu), executing test liveness from the command line, with and without using libtor

./minotari_node --base-path $(realpath .) --log-config $(realpath ./config)/log4rs_node.yml --network esmeralda --disable-splash-screen -p esmeralda.p2p.seeds.dns_seeds= -p esmeralda.p2p.seeds.peer_seeds= --watch "test-peer-liveness f6186e6f15af070d01d5aec8c5a53d81088c34b777cd0b25292d1cd522532462 /onion3/5uqpxi6ando6jrtcpj3aok4z7ab2nm36knfv2pzdf2hefdpkdcjnazid:18141 true true false" --non-interactive-mode -p base_node.use_libtor=true

• Base node (Ubuntu), with console, using libtor
• Console wallet (Ubuntu), with console, using libtor
• Console wallet (Ubuntu), recovery into console, using libtor

What process can a PR reviewer use to test or verify this change?

System-level testing
Code review

Breaking Changes

• None
• Requires data directory on base node to be deleted
• Requires hard fork
• Other - Please specify